pan069
Member
- Joined
- Jun 4, 2019
- Messages
- 49
Ah, right. So that is what I was going back and forth with Trixter about earlier. Using your suggestion of multiplying the porta parameter by 2 and not sliding on tick #0 (including not sliding on tick #0 of subsequent rows) sounds a whole lot better.With what you listed above, you increment it too much.
it is 5 Times per tick, not 5 then 6
I was wondering why your note values are half of what mine are? I.e. 320 to 160 instead of 640 to 320. We read from the same source and the period value for that note is 640 for me.
Yeah, I need to look into this. I don't see those other MODs changing the finetune value and I'm literally using the periods table I linked to earlier (the one from Brett Paterson's docs). And I am following the finetune for the channel, default is finetune #0. This is how I get my Amiga period value, pretty straight forward:Other mods that sounds bad may be because of the way you manage finetune
Code:
channel->period_value = _mod_tunings[channel->finetune][channel->period_index];
That is the eventual objective. Like Kennedy said "We do these things not because they are easy but because they are hard - Moon Landing Speech". I guess this MOD player is my moon landingOh, just saw that your target is assembly, for 8088/8086
May I ask you why ? Because it is not easy at all.
Everyone needs a hobby right? Some people collect stamps and others do crossword puzzles. Its more about solving a tricky problem than anything else I guess.
I have no illusions. I actually wrote the barebones of this MOD player for Windows, minus many of the effects, about 20 years ago. I recently dug out the source code and was wondering if I could port it to 16bit DOS as a xmas break project. The initial port took me about a day, it even ran on my 286/16 @8Khz (using the fixed point implementation).it took me years to have Mod Master at its current level of performance.
I expect many more hours of screwdriver work ahead before going into the Assembler part, first I'd like to get a decent reference implementation working in C and it seems that the effects are the hardest part.
Its nice though to be able to ask a question to others, I was stuck on this porta thing for about a week before I actually decided to reach out to the community. Sometimes you just go down the wrong path and just "rubber ducking" with other often gives you new avenues or insights you otherwise would not have been able to get to.
So, many thanks for engaging, its much appreciated!